netdev - Re: [PATCH 3/4 -rev1] Initilize and populate age field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 07 Aug 2007 10:22:15 +0530
From:	Varun Chandramohan <varunc@...ux.vnet.ibm.com>
To:	Eric Dumazet <dada1@...mosbay.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Patrick McHardy <kaber@...sh.net>,
	Oliver Hartkopp <socketcan@...tkopp.net>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [PATCH 3/4 -rev1] Initilize and populate age field

Hi Eric,

                Sorry for the late response. I just need few
clarifications.              

               *age = timeval_to_sec(&tv);

         >>>> +        NLA_PUT_U32(skb, RTA_AGE, *age);

         >>> here, what happens if sizeof(time_t) is not 4 ?

              Did you mean that the above should be like this?
               NLA_PUT_U32(skb, RTA_AGE, (unsigned int) *age);

     return tv->tv_sec + (tv->tv_usec ? 1 : 0);

     is much faster

         So can we say that "usec" is *always *< 1000000 ?
            

Regards,
Varun
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html