netdev - Re: [PATCH RFC]: napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 07 Aug 2007 21:08:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rdreier@...co.com
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	jgarzik@...ox.com, hadi@...erus.ca, rusty@...tcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V5

From: Roland Dreier <rdreier@...co.com>
Date: Tue, 07 Aug 2007 20:56:40 -0700

> First, there's pretty much universal agreement that
> patches should only contain one idea ("separate your changes"), that
> cleanups should not be mixed in with other changes, etc, etc.

Fine I'll revert.

> Although frankly, I have to say that your position here doesn't make
> much sense.

I think it does, the inconsistencies shown in each driver were
either 1) unnecessarily being different or 2) causing outright
races and bugs (see the discussions between Rusty and myself
during the first few revisions).

> In your earlier patches that got rid of netif_rx_reschedule(),
> your suggestion on how to handle the missed event race was to ask the
> hardware to trigger another event from the poll routine so it got
> rescheduled.

And I have rescinded this idea, and the removal of the resched
interface, for hardware not capable in response to your feedback.

> Being treated with the same level of collegiality that (I think) I
> treat you with would be appreciated.

My apologies.

I tend to lose it when people get hyper-critical on a change of which
I am doing all of the work editing a large number of drivers and for
which everyone benfits.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html