netdev - Re: [PATCH 2/14] nes: device structures and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	08 Aug 2007 14:38:10 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	ggrundstrom@...effect.com, rdreier@...co.com,
	ewg@...ts.openfabrics.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/14] nes: device structures and defines

Jeff Garzik <jeff@...zik.org> writes:
> > +			val, reg_index, addr, addr+4); */
> > +	writel(cpu_to_le32(reg_index), addr);
> > +	writel(cpu_to_le32(val),(u8 *)addr + 4);
> 
> wrong -- endian conversion macros not needed with writel()

Are you sure? I don't think that's true. e.g. powerpc writel 
doesn't convert endian

-Andi

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html