[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2007 14:55:11 +0200
From: Andi Kleen <andi@...stfloor.org>
To: Michael Buesch <mb@...sch.de>
Cc: Andi Kleen <andi@...stfloor.org>, Jeff Garzik <jeff@...zik.org>,
ggrundstrom@...effect.com, rdreier@...co.com,
ewg@...ts.openfabrics.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/14] nes: device structures and defines
On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote:
> On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote:
> > Jeff Garzik <jeff@...zik.org> writes:
> > > > + val, reg_index, addr, addr+4); */
> > > > + writel(cpu_to_le32(reg_index), addr);
> > > > + writel(cpu_to_le32(val),(u8 *)addr + 4);
> > >
> > > wrong -- endian conversion macros not needed with writel()
> >
> > Are you sure? I don't think that's true. e.g. powerpc writel
> > doesn't convert endian
>
> Andi, you are wrong.
> writeX take CPU endian args.
That is what I wrote.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists