netdev - Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Aug 2007 21:59:19 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	jbenc@...e.cz, flamingice@...rmilk.net, jeff@...zik.org
Subject: Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct	ieee80211_tx_packet_data

Johannes Berg napsal(a):
> On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote:
> 
>> +	if (control->flags & IEEE80211_TXCTL_REQ_TX_STATUS)
>> +		pkt_data->flags |= IEEE80211_TXPD_REQ_TX_STATUS;
>> +	if (control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT)
>> +		pkt_data->flags |= IEEE80211_TXPD_DO_NOT_ENCRYPT;
>> +	if (control->flags & IEEE80211_TXCTL_REQUEUE)
>> +		pkt_data->flags |= IEEE80211_TXPD_REQUEUE;
>> +	if (control->type == IEEE80211_IF_TYPE_MGMT)
>> +		pkt_data->flags |= IEEE80211_TXPD_MGMT_IFACE;
> 
> This looks weird. Can't we just use the same flags?

I don't think, that it must be subset one of each another in the future. (This
is why I created yet another bits defined).

Do we still want the same flags?

-- 
Jiri Slaby (jirislaby@...il.com)
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html