netdev - Re: [-mm patch] make types.h usable for non-gcc C parsers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2007 07:40:33 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Adrian Bunk <bunk@...nel.org>,
	Gabriel C <nix.or.die@...glemail.com>,
	linux-kernel@...r.kernel.org, Olaf Hering <olh@...e.de>,
	netdev@...r.kernel.org
Subject: Re: [-mm patch] make types.h usable for non-gcc C parsers

On Tue, 28 Aug 2007 10:43:15 +0200 Sam Ravnborg wrote:

> On Tue, Aug 28, 2007 at 12:37:04AM -0700, Andrew Morton wrote:
> > On Mon, 27 Aug 2007 23:27:43 +0200 Adrian Bunk <bunk@...nel.org> wrote:
> > 
> > > On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote:
> > > >...
> > > > WARNING: "div64_64" [net/netfilter/xt_connbytes.ko] has no CRC!
> > > >...
> > > 
> > > Patch below.
> > > 
> > > > Regards,
> > > > 
> > > > Gabriel
> > > 
> > > cu
> > > Adrian
> > > 
> > > 
> > > <--  snip  -->
> > > 
> > > 
> > > This patch makes the 64bit integers on 32bit architectures usable for
> > > all C parsers that know about "long long".
> > > 
> > > Signed-off-by: Adrian Bunk <bunk@...nel.org>
> > > 
> > 
> > Given that this patch (hopefully) fixes a problem in the current net-2.6.24
> > tree, I'm inclined to slip it into mainline immediately.
> > 
> > But I'd like a better description, please.  Which "non-gcc parser" are we
> > talking about here?  Something under ./scripts/.  Well, please identify it,
> > and describe what the problem is, and how the proposed patch will address
> > it.
> > 
> > Let's cc Sam too, as I guess he's the guy whose code just broke.
> 
> If my analysis is correct then genksyms fails to produce a CRC for div64_64 because
> genksyms does not know the __extension__ keyword.
> And this patch just paper over the real bug wich is in genksyms - right?
> 
> So we should fix the root cause here.
> 
> Googeling I did not find a good description of where __extension__ can be
> used so I fail to see where in the parse.y file I shal add the keyword.
> I think __extension__ may be used both as a part of an expression AND
> as part of a typedef (as in this case) but I wonder if this is where it is limited
> to be used.
> I would like to have this sorted out so we do not do a half-backed solution,
> and the proposed patch as it just paper over the real bug is no good.

I found only one gcc manual page on __extension__:

http://gcc.gnu.org/onlinedocs/gcc-4.1.2/gcc/Alternate-Keywords.html#Alternate-Keywords

(also found for other gcc versions)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html