netdev - Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2007 19:33:30 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jiri Slaby <jirislaby@...il.com>, linville@...driver.com,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote:
> On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote:
> > -ath5k-objs		= ath5k_base.o ath5k_hw.o ath5k_regdom.o
> > +ath5k-objs		= ath5k_base.o ath5k_hw.o ath5k_regdom.o \
> > +			  ath5k_hw_phy.o ath5k_hw_inivals.o
> 
> And while I'm at nitpicking :)
> 
> ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by
> most drivers and ath5k_hw_inivals.o mights aswell be something like
> ath5k_init.o

While we're at names... I personally much prefer a new directory ath5k
and then ath5k/hw.c etc. but it seems I'm pretty alone in that. But here
we already have at least four files now.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)