netdev - Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2007 10:45:03 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-08-27 at 14:26 -0700, Joe Perches wrote:

> 	char* print_mac(char* buf, const char* addr) {
> 		sprintf(buf,"%02x:...", addr[0]...)
> 		return buf;
> 	}
> 
> and used:
> 
> 	DECLARE_MAC_BUF(var); //same as char var[18];
> 	printk(MAC_FMT, MAC_ARG(var, addr));
> 
> which didn't require splitting printk()s
> 
> I've still got the original patch.
> It's just substituting EUI48 for MAC and forward porting.
> 
> Want something like that?

Sounds good to me. I'll have to port the wireless-dev code over to
introduce DECLARE_MAC_BUF but I can easily do that.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)