netdev - Re: [PATCH] e100 module loads 1/2 times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2007 23:34:38 +0200
From:	Willy Tarreau <w@....eu>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Cc:	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] e100 module loads 1/2 times

On Tue, Aug 28, 2007 at 02:43:23PM -0700, Brandeburg, Jesse wrote:
> Willy Tarreau wrote:
> > --- e100-3.5.17/src/e100.c.orig	2007-08-13 08:53:18 +0200
> > +++ e100-3.5.17/src/e100.c	2007-08-13 09:24:56 +0200
> > @@ -2934,13 +2934,13 @@
> >  		printk(KERN_INFO PFX "%s\n", DRV_COPYRIGHT);
> >  	}
> >  #ifdef E100_USE_REBOOT_NOTIFIER
> > -	retval = pci_register_driver(&e100_driver);
> > -	if (retval >= 0)
> > +	retval = pci_module_init(&e100_driver);
> > +	if (retval == 0)
> >  		register_reboot_notifier(&e100_notifier_reboot);
> > 
> >  	return retval;
> >  #else
> > -	return pci_register_driver(&e100_driver);
> > +	return pci_module_init(&e100_driver);
> >  #endif
> >  }
> > 
> 
> excellent catch willy!  Auke will make sure this gets upstream.
> 
> Thanks for your investigative work!  So strange that we had never gotten
> other reports of it.

I think that many places where e100 is found, there are at least 2 NICs,
and probably that the startup scripts load the module twice, resulting
in it finally working.

Could we update the e100 driver in 2.4 to 3.5.17+this fix ? The current
e100 driver (2.3.43) is plain broken regarding VLAN support. I already
have it working in my own kernels, and it definitely put an end to all
the problems I was facing before.

Thanks,
Willy

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html