netdev - Re: New NAPI API: Need for netif_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Sep 2007 17:27:33 -0700
From:	"Kok, Auke" <sofar@...-projects.org>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...l.org>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	NetDev <netdev@...r.kernel.org>
Subject: Re: New NAPI API: Need for netif_napi_remove() ?!

Kok, Auke wrote:
> David,
> 
>  From an old thread:
> 
>  > 5) Since, in the NETPOLL case, netif_napi_init() adds the NAPI struct
>  >   to the per-device list I renamed it to netif_napi_add().  Currently
>  >   no teardown is really necessary, anything that would need to be done
>  >   would be driver internal, so I didn't create the corollary
>  >   netif_napi_remove() for the time being.  Let's not add it unless it
>  >   really becomes necessary.
> 
> while coding the NAPI API changes into the ixgbe driver, I notice that I'm in 
> need for an implementation for netif_napi_remove(). The ixgbe driver itself 
> already modifies it's polling routing on open() and close() based on whether it 
> was able to acquire MSI-X vectors or not, and can thus logically change as the 
> system suspends/resumes and new hardware is inserted that change the balance in 
> the MSI-X vectors in the system. Or, even more bluntly, all MSI support is 
> disabled and we want the driver to come up in legacy mode and use a completely 
> different poll routine alltogether. We can't do this at probe time.
> 
> In any case I think we have a legitimate case for netif_napi_remove() to be 
> implemented.


hm, I spoke too soon, I think I can get by for now by just modifying 
adapter->napi.poll when needed, and this would be clean enough for now. This 
might change as I enable multiqueue in this driver later though.

Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html