netdev - Re: [PATCH] include listenq max backlog in /proc/net/tcp and include in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2007 19:15:39 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Rick Jones <rick.jones2@...com>
Cc:	Sridhar Samudrala <sri@...ibm.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] include listenq max backlog in /proc/net/tcp and
 include in tcp_info

On Tue, 11 Sep 2007 10:00:21 -0700
Rick Jones <rick.jones2@...com> wrote:

> Eric Dumazet wrote:
> > Sridhar Samudrala a écrit :
> > 
> >> On Mon, 2007-09-10 at 16:13 -0700, Rick Jones wrote:
> >>
> >>> Return some useful information such as the maximum listen backlog and
> >>> the current listen backlog in the tcp_info structure and have that 
> >>> match what one can see in /proc/net/tcp and /proc/net/tcp6.
> >>
> >>
> >> If we are also exporting max listen backlog, another place to
> >> consider adding this is to tcp_diag_get_info() called via INET_DIAG_INFO.
> >> Current listen backlog is returned in inet_diag_msg->idiag_rqueue.
> >> max listen backlog can be returned in inet_diag_msg->idiag_wqueue.
> >>
> > 
> > I agree, /proc/net/tcp is deprecated nowadays...
> 
> What takes its place?

ss command from iproute2 package ( http://linux-net.osdl.org/index.php/Iproute2 )

Problem with /proc/net/tcp is its quadratic time O(N^2) to output N lines...

On a loaded server :

# time ss|wc -l
 145695

real    0m9.383s
user    0m4.656s
sys     0m0.632s

# time netstat -an|wc -l
^C after some minutes .... no way...
real    3m23.825s
user    0m0.744s
sys     3m18.721s


> 
> > Rick, could you add this part in your patch, and add my Sign-off-by ?
> 
> My pleasure.
> 
> I have a small test program for the tcp_info bit - where do I go to find 
> how the inet diag stuff works?

ss state listen

> 
> BTW, what do people think about doing the same thing with the rxqueue 
> and txqueue's of netstat output?
>

I dont understand this question, I thought your patch already handled this 
(for the txqueue, since rxqueue is already there),  as netstat uses 
/proc/net/tcp (unfortunatly)

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html