netdev - Re: [PATCH] bonding: update some distro-specific documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Sep 2007 11:47:36 -0700
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Andy Gospodarek <andy@...yhouse.net>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: update some distro-specific documentation 

Andy Gospodarek <andy@...yhouse.net> wrote:

>I could do that, or we could just take this as-is and get initscripts
>fixed up to account for this.  Does that seem reasonable?

	Changing initscripts is fine, too, but is there then going to be
some (perhaps small) installed base for which the documentation will be
incorrect?

>I'd rather go that route, and I've even got a patch that *seems* to work
>already:
>
>--- initscripts-8.45.17.EL/sysconfig/network-scripts/ifup-eth.orig
>+++ initscripts-8.45.17.EL/sysconfig/network-scripts/ifup-eth
>@@ -125,7 +125,16 @@ if [ "$ISALIAS" = no ] && is_bonding_dev
>     for arg in $BONDING_OPTS ; do   
>         key=${arg%%=*};
>         value=${arg##*=};
>-        echo $value > /sys/class/net/${DEVICE}/bonding/$key
>+        OLDIFS=$IFS;
>+        IFS=',';
>+        if [ "${key}" = "arp_ip_target" ]; then
>+           for arp_ip in $value; do
>+             echo +$arp_ip > /sys/class/net/${DEVICE}/bonding/$key
>+           done
>+        else
>+           echo $value > /sys/class/net/${DEVICE}/bonding/$key
>+        fi
>+        IFS=$OLDIFS;
>     done
>
>     /sbin/ip link set dev ${DEVICE} up

	That looks like it should do the right thing, although I didn't
actually try it.  The other bonding sysfs thingies that use the "+" type
of syntax don't appear in BONDING_OPTS.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html