lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Sep 2007 15:17:37 -0400 From: "Jon Smirl" <jonsmirl@...il.com> To: "Domen Puncer" <domen@...erock.org> Cc: netdev@...r.kernel.org, linuxppc-embedded@...abs.org, sven@...erlinux.fr Subject: Re: [PATCH] phy: export phy_mii_ioctl On 9/18/07, Domen Puncer <domen@...erock.org> wrote: > More testing and getting it to work properly on Phytec pcm030 would > be great. I compiled it as a module: CC [M] drivers/net/fec_mpc52xx/fec.o drivers/net/fec_mpc52xx/fec.c:613: warning: 'mpc52xx_fec_mac_setup' defined but not used This code needs to be enclosed in "#ifndef MODULE". But why aren't you using module_param() to make a string parameter and then copy it into mpc52xx_fec_mac_addr[] if the parameter is not null? If it is a module param you need to use fec_mpc52xx_phy.mpc52xx-mac="xxxx" instead of just mpc52xx-mac. The way it is not you can't use mpc52xx-mac when built as a module. static int __init mpc52xx_fec_mac_setup(char *mac_address) { int i; u64 val64; val64 = simple_strtoull(mac_address, NULL, 16); for (i = 0; i < 6; i++) mpc52xx_fec_mac_addr[5-i] = val64 >> (i*8); return 0; } __setup("mpc52xx-mac=", mpc52xx_fec_mac_setup); -- Jon Smirl jonsmirl@...il.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists