lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Sep 2007 15:08:22 +0200 From: Patrick McHardy <kaber@...sh.net> To: Alexey Kuznetsov <kuznet@....inr.ac.ru> CC: Chuck Ebbert <cebbert@...hat.com>, Netdev <netdev@...r.kernel.org> Subject: Re: SFQ qdisc crashes with limit of 2 packets Alexey Kuznetsov wrote: > Hello! > >>CCed Alexey just to be safe, but I think the patch should be fine. > > > Yes. But what'a about limit == 1? tc prohibits this case, but it is still > not nice to have the bug in kernel. Plus, code remains creepy, the check > > + if (++sch->q.qlen < q->limit) { > > still looks as a scary off-by-one. I would go all the way: replace this > with natural: > > if (++sch->q.qlen <= q->limit) { > > and maxed q->limit at SFQ_DEPTH-2. Patch enclosed. Thats even better, thanks :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists