netdev - Re: Please pull 'z1211' branch of wireless-2.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 22 Sep 2007 16:47:45 +0200
From:	Michael Buesch <mb@...sch.de>
To:	Ulrich Kunitz <kune@...ne-taler.de>
Cc:	"John W. Linville" <linville@...driver.com>,
	Daniel Drake <dsd@...too.org>, davem@...emloft.net,
	jeff@...zik.org, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: Please pull 'z1211' branch of wireless-2.6

On Saturday 22 September 2007, Ulrich Kunitz wrote:
> Michael Buesch wrote:
> 
> > On Saturday 22 September 2007 11:48:00 Ulrich Kunitz wrote:
> > > A real high-quality driver will require Johannes' proposed
> > > mac80211 driver interface changes to be merged and TX
> > > confirmations handled in a way, that the semantics can really be
> > > supported by the driver. (Michael Buesh's patch is taping over the
> > > issue.)
> > 
> > No it is not. It is fixing the issue. It fixes the following issues:
> 
> > * You must ignore the Txstat-requested bit in the driver.
> 
> If that is really the case the flag should be removed from
> mac80211. There is no way for somebody looking at the code to know
> this.

It is used internally in mac80211.

> > * You must report bad frames with the excessive_retries set.
> 
> All bad frames or only those with actual excessive retries? Your patch
> set the excessive_retries flag for packets that couldn't be
> transmitted to the device because of an USB error. If the flag
> should be set for all kinds of errors it should be renamed.

Well, there is no better flag to set, currently.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html