lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Sep 2007 12:32:44 -0700 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Jeff Garzik <jgarzik@...ox.com> Cc: netdev@...r.kernel.org Subject: [PATCH 1/2] sky2: FE+ vlan workaround The FE+ workaround means the driver can no longer trust the status register to indicate VLAN tagged frames. The fix for this is to just disable VLAN acceleration for that chip version. Tested and works fine. This patch applies to 2.6.23-rc8 after yesterday's patch: sky2 FE+ receive status workaround Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org> --- a/drivers/net/sky2.c 2007-09-27 08:45:13.000000000 -0700 +++ b/drivers/net/sky2.c 2007-09-27 09:43:15.000000000 -0700 @@ -3970,8 +3970,12 @@ static __devinit struct net_device *sky2 dev->features |= NETIF_F_HIGHDMA; #ifdef SKY2_VLAN_TAG_USED - dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX; - dev->vlan_rx_register = sky2_vlan_rx_register; + /* The workaround for FE+ status conflicts with VLAN tag detection. */ + if (!(sky2->hw->chip_id == CHIP_ID_YUKON_FE_P && + sky2->hw->chip_rev == CHIP_REV_YU_FE2_A0)) { + dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX; + dev->vlan_rx_register = sky2_vlan_rx_register; + } #endif /* read the mac address */ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists