netdev - Re: [PATCH] do not give access to 1-1024 ports for autobinding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Oct 2007 10:12:03 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	"Denis V. Lunev" <dlunev@...il.com>
Cc:	"Denis V. Lunev" <den@...nvz.org>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] do not give access to 1-1024 ports for autobinding

On Wed, 10 Oct 2007 20:59:13 +0400
"Denis V. Lunev" <dlunev@...il.com> wrote:

> Stephen Hemminger wrote:
> > On Wed, 10 Oct 2007 18:34:49 +0400
> > "Denis V. Lunev" <den@...nvz.org> wrote:
> > 
> >> This patch prevents possibility to give 1-1024 port range for autobinding.
> >> {1, 1} may only takes some sense for deep embedded people.
> >>
> >> Signed-off-by: Denis V. Lunev <den@...nvz.org>
> >>
> >> --- ./net/ipv4/sysctl_net_ipv4.c.port2	2007-10-10 17:46:48.000000000 +0400
> >> +++ ./net/ipv4/sysctl_net_ipv4.c	2007-10-10 18:08:00.000000000 +0400
> >> @@ -25,7 +25,7 @@ extern int sysctl_ip_nonlocal_bind;
> >>  #ifdef CONFIG_SYSCTL
> >>  static int zero;
> >>  static int tcp_retr1_max = 255;
> >> -static int ip_local_port_range_min[] = { 1, 1 };
> >> +static int ip_local_port_range_min[] = { 1024, 1024 };
> >>  static int ip_local_port_range_max[] = { 65535, 65535 };
> >>  #endif
> >>  
> >> -
> > 
> > That only limits the sysctl, which seems completely counter productive.
> > Sounds like more of the "stop root from shooting themselves" patches.
> > 
> 
> They have sense for the case of multiple network namespaces, where root
> in the other namespace can be treated as a user to initial namespace.

IMHO  don't want to treat root as a complete idiot like normal users.
As long as what root requests doesn't create a security problem, it
should be allowed.  The port space is per namespace right? The sysctl
values should be per namespace as well.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html