netdev - Re: [PATCH 2/2] Interface group match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Oct 2007 16:46:43 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Patrick McHardy <kaber@...sh.net>
cc:	Laszlo Attila Toth <panther@...abit.hu>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [PATCH 2/2] Interface group match - netfilter part


On Oct 16 2007 10:30, Patrick McHardy wrote:

>> +static int match(const struct sk_buff *skb,

Potential symbol clash, name it ifgroup_match() for example.

>> +      const struct net_device *in,
>> +      const struct net_device *out,
>> +      const struct xt_match *match,
>> +      const void *matchinfo,
>> +      int offset,
>> +      unsigned int protoff,
>> +      int *hotdrop)

2.6.23 => bool ifgroup_match(... bool *hotdrop)

>> +static struct xt_match ifgroup_match = {
>> +	.name		= "ifgroup",
>> +	.match		= match,
>> +	.matchsize	= sizeof(struct xt_ifgroup_info),
>> +	.family		= AF_INET,
>> +	.me		= THIS_MODULE,
>> +};
>> +
>> +static struct xt_match ifgroup6_match = {
>> +	.name		= "ifgroup",
>> +	.match		= match,
>> +	.matchsize	= sizeof(struct xt_ifgroup_info),
>> +	.family		= AF_INET6,
>> +	.me		= THIS_MODULE,
>> +};
>
> __read_mostly

And actually, an array,

	static struct xt_match ifgroup_match[] __read_mostly = {
		...
	}

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html