lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Oct 2007 19:08:44 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Jarek Poplawski <jarkao2@...pl> Cc: "Maciej W. Rozycki" <macro@...ux-mips.org>, Andy Fleming <afleming@...escale.com>, Andrew Morton <akpm@...ux-foundation.org>, Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes > Btw., since, because of this patch, I've had a one more look at phy.c > and there are a few more doubts, so this time I'll try to bother you > for real: .../... While there... is somebody interested in making the whole PHY lib operate a task level and use mutexes instead of spinlock ? I need that for drivers like EMAC (who use their own PHY layer for now), and I might even give a go at adapting phylib myself, but I'd like to take the temperature about it first. Basically, there is nothing in phylib that is performance critical or such that requires it to run at irq time and/or use locks. On the other hand, it complicates things in various areas. The most obvious one being that it prevents the network driver mii access callbacks from sleeping which can be annoying as MDIO can be slow, and some drivers have fancy muxes in there that are better off mutexed than spinlocked. Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists