netdev - Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Oct 2007 13:09:57 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Dale Farnsworth <dale@...nsworth.org>,
	Nicolas Pitre <nico@...vell.com>,
	Tzachi Perelstein <tzachi@...vell.com>,
	Manas Saksena <msaksena@...vell.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header

On Fri, Oct 19, 2007 at 09:30:48AM +0100, Christoph Hellwig wrote:

> > Move the mv643xx's ethernet-related register definitions from
> > include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since
> > they aren't of any use outside the ethernet driver.
> > 
> > Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>
> > Acked-by: Tzachi Perelstein <tzachi@...vell.com>
> > 
> > Index: linux-2.6/drivers/net/mv643xx_eth.h
> > ===================================================================
> > --- linux-2.6.orig/drivers/net/mv643xx_eth.h
> > +++ linux-2.6/drivers/net/mv643xx_eth.h
> > @@ -7,7 +7,7 @@
> >  #include <linux/workqueue.h>
> >  #include <linux/mii.h>
> >  
> > -#include <linux/mv643xx.h>
> > +#include <linux/mv643xx_eth.h>
> 
> Isn't it a little too confusing to have two headers with the same name,
> one in drivers/net and one in include/linux?

Perhaps we can fold the drivers/net one into drivers/net/mv643xx_eth.c?
Since nothing else includes drivers/net/mv643xx_eth.h anyway, there's
not much point in having it separate.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html