lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Oct 2007 16:49:15 +0400 From: Alexey Dobriyan <adobriyan@...ru> To: Pavel Emelyanov <xemul@...nvz.org> Cc: David Miller <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org>, devel@...nvz.org Subject: Re: [Devel] [PATCH 1/5] Cut off br_port fied from net_device On Mon, Oct 22, 2007 at 04:33:33PM +0400, Pavel Emelyanov wrote: > And add the forward declaration for br_handle_frame_hook in > include/linux/if_bridge.h > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -699,8 +699,10 @@ struct net_device > /* Network namespace this network device is inside */ > struct net *nd_net; > > +#if defined(CONFIG_BRIDGE) || defined(CONFIG_BRIDGE_MODULE) > /* bridge stuff */ > struct net_bridge_port *br_port; > +#endif Such ifdefs are troublesome, because one can compile kernel with CONFIG_BRIDGE=n and later decide he needs BRIDGE=m and go boom. IPv6 -- the biggest violator of this rule should not be taken as example. :^) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists