| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Oct 2007 11:25:58 -0700 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Roel Kluin <12o3l@...cali.nl> Cc: netdev@...r.kernel.org Subject: Re: [PATCH 1] net: fix and typo's On Fri, 26 Oct 2007 19:07:10 +0200 Roel Kluin <12o3l@...cali.nl> wrote: > A few patches with changes to net code. I have sent these to the lkml > previously, but they were not yet merged. I am fairly new to kernel > programming, so it is possible that I make some mistakes. I'll explain my > rationale, please nack if incorrect, an additional bit of explanation is > appreciated even more. > > The condition '!x & y,' does make little sense: the '!' has a higher > priority than '&'. It behaves therefore like '!x && y'. In the case > bitanding flags, however, '!(x & y)' appears to be desired. > > Warning: the change of '!x & y,' to '!(x & y)' may change behavior. if > not desired, I propose changing this to '!x && y', to make it explicitly > clear. > > These '&' typo's can be spotted with: > a="A-Za-z0-9_" > git-grep "\![^$a()]*[$a]\+\([$a.]*\|->\)*\(\[[$a.]*\]\)\?[ \W]*&[^&]\+" > > -- > Fix priority mistakes similar to '!x & y' > > Signed-off-by: Roel Kluin <12o3l@...cali.nl> I agree these look good, but maybe they should be broken into separate patches to make bisection of any induced regressions easier. Stephen Hemminger <shemminger@...ux-foundation.org> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists