netdev - Re: [patch 1/1][IPV6] resend: remove duplicate call to proc_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Oct 2007 14:53:53 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Daniel Lezcano <dlezcano@...ibm.com>
Cc:	davem@...emloft.net, containers@...ts.osdl.org,
	netdev@...r.kernel.org
Subject: Re: [patch 1/1][IPV6] resend:  remove duplicate call to proc_net_remove

Daniel Lezcano <dlezcano@...ibm.com> writes:

> The file /proc/net/if_inet6 is removed twice.
> First time in:
>         inet6_exit
>              ->addrconf_cleanup
> And followed a few lines after by:
>         inet6_exit
>              -> if6_proc_exit
>
> Signed-off-by: Daniel Lezcano <dlezcano@...ibm.com>
Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Looks like a good clean up to me.




> ---
>  net/ipv6/addrconf.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> Index: net-2.6/net/ipv6/addrconf.c
> ===================================================================
> --- net-2.6.orig/net/ipv6/addrconf.c
> +++ net-2.6/net/ipv6/addrconf.c
> @@ -4288,8 +4288,4 @@ void __exit addrconf_cleanup(void)
>  	del_timer(&addr_chk_timer);
>  
>  	rtnl_unlock();
> -
> -#ifdef CONFIG_PROC_FS
> -	proc_net_remove(&init_net, "if_inet6");
> -#endif
>  }
>
> -- 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html