netdev - Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu,  1 Nov 2007 13:52:13 -0700
From:	Chris Poon <dev-null@...us.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	bugme-daemon@...zilla.kernel.org, jeff@...zik.org
Subject: Re: [Bugme-new] [Bug 9270] New: sunhme requires lower MTU to handle 802.1q frames

Forgot to add that only changing BMAC_TXMAX & BMAC_RXMAX wouldn't work
for me, until I changed 2 skb_put as well (which is in the patch that
I submitted in bugzilla). Dug up some really old threads on the net
and found out that this was reported before

Quoting Andrew Morton <akpm@...ux-foundation.org>:

> On Wed, 31 Oct 2007 16:35:57 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
> > From: Andrew Morton <akpm@...ux-foundation.org>
> > Date: Wed, 31 Oct 2007 15:43:01 -0700
> > 
> > > > sunhme requires lower MTU to handle 802.1q frames - even though the
> PCI
> > > > driver supported VLAN tagging, you cannot do full MTU @ 1500 because
> the
> > > > driver doesn't set the card to transfer more the extra bytes for a
> 802.1q
> > > > frame at 1500 MTU.
> > 
> > It supports VLAN tagging by accident, the NETIF_F_VLAN_CHALLENGED
> > flag should be set both in the PCI and non-PCI cases.
> > 
> > Jeff, please apply, thanks:
> > 
> > [SUNHME]: Fix missing NETIF_F_VLAN_CHALLENGED on PCI happy meals.
> > 
> > No HME parts can do VLANs correctly.
> > 
> > Signed-off-by: David S. Miller <davem@...emloft.net>
> > 
> > diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
> > index 120c8af..c20a3bd 100644
> > --- a/drivers/net/sunhme.c
> > +++ b/drivers/net/sunhme.c
> > @@ -3143,8 +3143,8 @@ static int __devinit happy_meal_pci_probe(struct
> pci_dev *pdev,
> >  	dev->irq = pdev->irq;
> >  	dev->dma = 0;
> >  
> > -	/* Happy Meal can do it all... */
> > -	dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
> > +	/* Happy Meal can do it all... except VLAN. */
> > +	dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_VLAN_CHALLENGED;
> >  
> >  #if defined(CONFIG_SBUS) && defined(CONFIG_PCI)
> >  	/* Hook up PCI register/dma accessors. */
> 
> I forgot to add my standard "please reply via emailed reply-to-all, not via
> the bugzilla web interface", so Chris has gone and attempted to communicate
> with us via the bugzilla UI (sigh).
> 
> He asked
> 
> "Even though it appears to work after I bumped the BMAC_TXMAX / BMAC_RXMAX?"
> 
> 
> 




-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html