netdev - Re: [PATCH 4/4] [TCP]: Split SACK FRTO flag clearing (fixes FRTO corner case bug)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 10 Nov 2007 21:24:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] [TCP]: Split SACK FRTO flag clearing (fixes FRTO
 corner case bug)

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Sat, 10 Nov 2007 12:56:02 +0200

> In case we run out of mem when fragmenting, the clearing of
> FLAG_ONLY_ORIG_SACKED might get missed which then feeds FRTO
> with false information. Move clearing outside skb processing
> loop so that it will get executed even if the skb loop
> terminates prematurely due to out-of-mem.
> 
> Besides, now the core of the loop truly deals with a single
> skb only, which also enables creation a more self-contained
> of tcp_sacktag_one later on.
> 
> In addition, small reorganization of if branches was made.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html