| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Nov 2007 18:09:46 -0800 (PST) From: David Miller <davem@...emloft.net> To: benh@...nel.crashing.org Cc: johannes@...solutions.net, netdev@...r.kernel.org, linuxppc-dev@...abs.org, shemminger@...ux-foundation.org Subject: Re: [PATCH] sungem: fix suspend regression due to NAPI changes From: Benjamin Herrenschmidt <benh@...nel.crashing.org> Date: Tue, 13 Nov 2007 09:32:46 +1100 > > On Mon, 2007-11-12 at 18:45 +0100, Johannes Berg wrote: > > Commit bea3348e (the NAPI changes) made sungem unconditionally enable > > NAPI when resuming and unconditionally disable when suspending, this, > > however, makes napi_disable() hang when suspending when the interface > > was taken down before suspend because taking the interface down also > > disables NAPI. This patch makes touching the napi struct in > > suspend/resume code paths depend on having the interface up, thereby > > fixing the hang on suspend. > > > > The patch also moves the napi_disable() in gem_close() under the lock so > > that the NAPI state is always modified atomically together with the > > "opened" variable. > > > > Signed-off-by: Johannes Berg <johannes@...solutions.net> > > Thanks for fixing that ! > > Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org> Indeed, thanks a lot Johannes. Patch applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists