lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Nov 2007 21:47:21 -0800 (PST) From: David Miller <davem@...emloft.net> To: herbert@...dor.apana.org.au Cc: netdev@...eo.de, netdev@...r.kernel.org Subject: Re: [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section From: Herbert Xu <herbert@...dor.apana.org.au> Date: Tue, 13 Nov 2007 19:51:19 +0800 > On Tue, Nov 13, 2007 at 03:33:48AM -0800, David Miller wrote: > > > > Make 'lastused' an 'unsigned long' (that's all that get_seconds() > > gives to us anyways), fix up the nla_total_size(x->lastused) thing in > > net/xfrm/xfrm_user.c, and then you can remove this lock acquisition > > completely because the store into x->lastused will now be atomic and > > therefore locks aren't protecting anything. > > Brilliant, make that patch 25/25 :) > > [IPSEC]: Make x->lastused an unsigned long > > Currently x->lastused is u64 which means that it cannot be read/written > atomically on all architectures. David Miller observed that the value > stored in it is only an unsigned long which is always atomic. > > So based on his suggestion this patch changes the internal representation > from u64 to unsigned long while the user-interface still refers to it as > u64. > > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> Applied to net-2.6.25 :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists