netdev - Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Nov 2007 20:21:37 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Wang Chen <wangchen@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>, andi@...stfloor.org,
	billfink@...dspring.com, netdev@...r.kernel.org,
	gerrit@....abdn.ac.uk, bfields@...ldses.org, neilb@...e.de,
	okir@...ad.swb.de
Subject: Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

On Thu, Nov 29, 2007 at 03:55:38PM +0800, Wang Chen wrote:
> 
> I tested nfsv3 & nfsv4. It seems that nfs calls recvmsg() like
> following:nfsd()->svc_recv()->svc_udp_recvfrom()->udp_recvmsg().
> So, I think putting the udpInDatagrams increment in udp_recvmsg()
> is enough.
> 
> FYI:
> http://www.mail-archive.com/netdev@vger.kernel.org/msg13817.html

Excellent.  They now do a recvmsg first with no buffer to get
meta-information, which just happens to increment the counters.

Could you please resubmit the patch then?

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html