netdev - Re: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2007 10:58:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	den@...nvz.org
Cc:	containers@...ts.osdl.org, devel@...nvz.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not
 modified, make them const

From: "Denis V. Lunev" <den@...nvz.org>
Date: Wed, 12 Dec 2007 14:05:55 +0300

> -static int halve_threshold = 25;
> -static int inflate_threshold = 50;
> -static int halve_threshold_root = 15;
> -static int inflate_threshold_root = 25;

halve_threshold_root and inflate_threshold_root have different
values in the net-2.6.25 tree.

What tree are you patching against?  These were changed way
back in:

commit 965ffea43d4ebe8cd7b9fee78d651268dd7d23c5
Author: Robert Olsson <robert.olsson@....uu.se>
Date:   Mon Mar 19 16:29:58 2007 -0700

    [IPV4]: fib_trie root node settings
    
    The threshold for root node can be more aggressive set to get
    better tree compression. The new setting mekes the root grow
    from 16 to 19 bits and substansial improvemnt in Aver depth
    this with the current table of 214393 prefixes
    
    But really the dynamic resize should need more investigation
    both in terms convergence and performance and maybe it should
    be possible to change...
    
    Maybe just for the brave to start with or we may have to back
    this out.

Please don't waste my time like this.  Always submit patches
against the current tree, even if you "think" the files
you are patching haven't changed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html