lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Dec 2007 21:44:29 -0800 (PST) From: David Miller <davem@...emloft.net> To: herbert@...dor.apana.org.au Cc: akpm@...ux-foundation.org, netdev@...r.kernel.org, ebiederm@...ssion.com Subject: Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL() From: Herbert Xu <herbert@...dor.apana.org.au> Date: Sat, 15 Dec 2007 21:10:16 +0800 > On Sat, Dec 15, 2007 at 02:48:10AM -0800, Andrew Morton wrote: > > > > Now as a separate issue we (ie: you) need to work out what _other_ things > > you want ASSERT_RTNL to check apart from "rtnl must be held". > > Since we have now established that ASSERT_RTNL never actually > warned about usage on paths with BH off, I think Eric's original > patch is fine as it is and I owe him an apology. Ok, same here... Such situations (ASSERT_RTNL() in atomic context) have always been bugs though, and that continues to be true and I think the check should be added somehow. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists