netdev - Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Dec 2007 09:21:06 +0200 (EET)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	Eric Dumazet <dada1@...mosbay.com>
cc:	"David S. Miller" <davem@...emloft.net>,
	"YOSHIFUJI Hideaki / 吉藤英明" 
	<yoshfuji@...ux-ipv6.org>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

On Fri, 21 Dec 2007, Eric Dumazet wrote:

> Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler
> to emit an integer divide, while we can help it to use a right shift,
> less expensive.

Can't you just change tot_len to unsigned here? It's just sizeof and some 
positive constants added...

-- 
 i.
View attachment "tcp_ipv6.patch" of type "text/plain" (415 bytes)