netdev - [RFC] potential bug in cxgb3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 23 Dec 2007 20:01:04 +0000
From:	Al Viro <viro@....linux.org.uk>
To:	divy@...lsio.com
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: [RFC] potential bug in cxgb3

int t3_seeprom_wp(struct adapter *adapter, int enable)
{
        return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? 0xc : 0);
}

looks fishy, since t3_seeprom_write() takes the last argument in little-endian,
converts to host-endian and feeds it to pci_write_config_dword().  Passing it
a host-endian instead will end up with different values seen by the card on
l-e and b-e hosts.  Shouldn't it be s/0xc/cpu_to_le32(0xc) ?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html