netdev - Re: [ETH]: Combine format_addr() with print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Dec 2007 21:28:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	joe@...ches.com, netdev@...r.kernel.org, anilgv@...adcom.com,
	michaelc@...wisc.edu, david.somayajulu@...gic.com
Subject: Re: [ETH]: Combine format_addr() with print_mac().

From: "Michael Chan" <mchan@...adcom.com>
Date: Sun, 23 Dec 2007 16:20:35 -0800

> Here's the revised patch:
> 
> [ETH]: Combine format_addr() with print_mac().
> 
> print_mac() used many most net drivers and format_addr() used by
> net-sysfs.c are very similar and they can be intergrated.
> 
> format_addr() is also identically redefined in the qla4xxx iscsi
> driver.
> 
> Export a new function sysfs_format_mac() to be used by net-sysfs,
> qla4xxx and others in the future.  Both print_mac() and
> sysfs_format_mac() call _format_mac_addr() to do the formatting.
> 
> Changed print_mac() to use unsigned char * to be consistent with
> net_device struct's dev_addr.  Added buffer length overrun checking
> as suggested by Joe Perches.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied to net-2.6.25, thanks Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html