netdev - Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Dec 2007 10:44:46 -0500
From:	"chas williams - CONTRACTOR" <chas@....nrl.navy.mil>
To:	Christoph Hellwig <hch@...radead.org>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

In message <20071231090957.GA28855@...radead.org>,Christoph Hellwig writes:
>> +#define LLC		0xaa, 0xaa, 0x03
>> +#define SNAP_BRIDGED	0x00, 0x80, 0xc2
>> +#define SNAP_ROUTED	0x00, 0x00, 0x00
>> +#define PID_ETHERNET	0x00, 0x07
>> +#define ETHERTYPE_IPV4	0x08, 0x00
>> +#define ETHERTYPE_IPV6	0x86, 0xdd
>> +#define PAD_BRIDGED	0x00, 0x00
...
>> +	{ LLC, SNAP_BRIDGED, PID_ETHERNET, PAD_BRIDGED };
>> +static unsigned char llc_oui_ipv4[] =
>> +	{ LLC, SNAP_ROUTED, ETHERTYPE_IPV4 };
>> +static unsigned char llc_oui_ipv6[] =
>> +	{ LLC, SNAP_ROUTED, ETHERTYPE_IPV6 };
>
>I think this should be in a global header.  And IIRC we already have
>at least some of these somewhere as part of the general llc support.

sounds good to me, but i dont think its already in a generalized
llc header.  the only appearance i can find is:

net/ieee80211/ieee80211_rx.c:static unsigned char rfc1042_header[] = { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 };
net/ieee80211/ieee80211_rx.c:    { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 };
net/ieee80211/ieee80211_tx.c:      | 0xAA | 0xAA |0x03 (UI)|0x00-00-F8|      |         |
net/mac80211/util.c:    { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 };
net/mac80211/util.c:    { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 };

any suggestions on how and where you would like to see these structures?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html