netdev - Re: [IPSEC] flow : NUMA aware hash table allocation

lists.openwall.net		lists / announce john-users owl-users popa3d-users / xvendor oss-security / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4
Open Source and information security mailing list archives

This website is powered by Openwall GNU/*/Linux security-enhanced OS

[<prev] [next>] [<thread-prev] [month] [year] [list]

Date:	Tue, 01 Jan 2008 19:23:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Subject: Re: [IPSEC] flow : NUMA aware hash table allocation

From: Eric Dumazet <dada1@...mosbay.com>
Date: Tue, 01 Jan 2008 13:44:15 +0100

> Using __get_free_pages() has some drawbacks :
> 
> 1) Not NUMA aware
> 
> 2) 2^X page granularity :
> On arches with big PAGE_SIZE, we waste some ram for each cpu.
> 
> (We currently use 1024 pointers, that is at most 8192 bytes, but
> PAGE_SIZE can be 65536 for example : With say 64 possible cpus,
> thats about 56*64 Kbytes that are wasted)
> 
> Using kmalloc_node() can help to solve these two points.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied, thanks Eric.

It reminds me that flow_hash_shift should at some point be dynamically
sized.  However, currently the flow cache isn't so heavily used and
there are more important fish to fry right now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html