lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 06 Jan 2008 11:29:35 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: ilpo.jarvinen@...sinki.fi (Ilpo J??rvinen) Cc: davem@...emloft.net, netdev@...r.kernel.org, acme@...hat.com, ilpo.jarvinen@...sinki.fi, paul.moore@...com, latten@...ibm.com Subject: Re: [PATCH 3/4] [XFRM]: Kill some bloat Ilpo J??rvinen <ilpo.jarvinen@...sinki.fi> wrote: > > Signed-off-by: Ilpo J??rvinen <ilpo.jarvinen@...sinki.fi> Acked-by: Herbert Xu <herbert@...dor.apana.org.au> > #ifdef CONFIG_AUDITSYSCALL > -static inline void xfrm_audit_helper_sainfo(struct xfrm_state *x, > - struct audit_buffer *audit_buf) > +static void xfrm_audit_helper_sainfo(struct xfrm_state *x, > + struct audit_buffer *audit_buf) We should never use inline except when it's on the fast path and this is definitely not a fast path. If a function ends up being called just once the compiler will most likely inline it anyway, making the use of the keyword inline redundant. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists