netdev - Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Jan 2008 08:23:28 -0800
From:	David Stevens <dlstevens@...ibm.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	wangchen@...fujitsu.com (Wang Chen)
Subject: Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

Herbert Xu <herbert@...dor.apana.org.au> wrote on 01/16/2008 03:49:01 AM:

> Actually having the icmp_out_count call in ip_push_pending_frames seems
> inconsistent.  Having it there means that we count raw socket ICMP 
packets
> too.  But we don't do that for any other protocol, e.g., raw UDP packets
> don't get counted.

Herbert,
        The patch was to support the ICMPMsgStats table. Since none of 
certain
types of output ICMP messages are generated by the kernel, but are 
required
by the RFC, counting raw sockets is intentional (and the only way those 
ICMP
types can be counted at all).
        Raw UDP packets would not be counted either before or after the 
patch,
but aren't part of the ICMPMsgStats table. Adding those might be 
worthwhile,
but it isn't quite the hole that the ICMP out stats were, since there is a
cooked interface for UDP output that counts the common use, at least.

Wang,
        I think your patch is correct; did you test the same case for 
IPv6?

 +-DLS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html