lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jan 2008 21:38:23 -0800 From: Kevin Hilman <khilman@...sta.com> To: netdev@...r.kernel.org Cc: Nicolas Pitre <nico@....org>, Kevin Hilman <khilman@...sta.com> Subject: [PATCH] SMC91x: poll_controller(): check for interrupts before calling handler When using polling, smc_poll_controller() can call smc_interrupt() when there are likely to be no real interrups. This will trigger the "spurious interrupt" printk whenever the driver is being polled. Instead, check for actual interrupts before calling smc_interrupt() Signed-off-by: Kevin Hilman <khilman@...sta.com> Signed-off-by: Nicolas Pitre <nico@....org> --- drivers/net/smc91x.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c index 7da7589..64ef6c1 100644 --- a/drivers/net/smc91x.c +++ b/drivers/net/smc91x.c @@ -1350,8 +1350,12 @@ static irqreturn_t smc_interrupt(int irq, void *dev_id) */ static void smc_poll_controller(struct net_device *dev) { + struct smc_local *lp = netdev_priv(dev); + void __iomem *ioaddr = lp->base; + disable_irq(dev->irq); - smc_interrupt(dev->irq, dev); + if (SMC_GET_INT() & SMC_GET_INT_MASK()) + smc_interrupt(dev->irq, dev); enable_irq(dev->irq); } #endif -- 1.5.3.7 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists