netdev - Re: sis190 build breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jan 2008 16:42:09 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	maximilian attems <max@...o.at>
Cc:	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org,
	samr <sam@...nborg.org>
Subject: Re: sis190 build breakage

On Wed, 30 Jan 2008 00:12:23 +0100 maximilian attems wrote:

> On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote:
> > maximilian attems <max@...o.at> :
> > [...]
> > > probably i should to get interesting info.
> > 
> > Don't bother.
> > 
> > $ less +/devinitdata Documentation/pci.txt
> > [...]
> > Tips on when/where to use the above attributes:
> >         o The module_init()/module_exit() functions (and all
> >           initialization functions called _only_ from these)
> >           should be marked __init/__exit.
> > 
> >         o Do not mark the struct pci_driver.
> > 
> >         o The ID table array should be marked __devinitdata.
> >
> > Could our documentation be wrong ?
> 
> yep that was what i had in mind, so i was a bit baffled..
> 
> randy any insight?

Hi,

I can't reproduce the problem... :(

I tend to expect something with Sam's new section mismatch detection.
Maybe it's a lot better and found a real issue, but AFAIK this table
can still be marked as __devinitdata.

Sam cc-ed.


> > 
> > diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
> > index b570402..2e9e88b 100644
> > --- a/drivers/net/sis190.c
> > +++ b/drivers/net/sis190.c
> > @@ -326,7 +326,7 @@ static const struct {
> >  	{ "SiS 191 PCI Gigabit Ethernet adapter" },
> >  };
> >  
> > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
> > +static struct pci_device_id sis190_pci_tbl[] = {
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
> >  	{ 0, },
> 
> thanks for quick fix.

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html