netdev - RE: [PATCH] Disable TSO for non standard qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Feb 2008 17:51:17 -0800
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"Jarek Poplawski" <jarkao2@...il.com>, <hadi@...erus.ca>
Cc:	"Patrick McHardy" <kaber@...sh.net>,
	"Andi Kleen" <andi@...stfloor.org>, "Glen Turner" <gdt@....id.au>,
	"Stephen Hemminger" <shemminger@...ux-foundation.org>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH] Disable TSO for non standard qdiscs

> I totally disagree with these POVs:
> 
> - 10G cards should be treated by default as 10G cards - not 
> DSL modems,
>   and common users shouldn't have to read any warnings or configs to
>   see this.
> - tc with TBF or HTB are professional tools; there should be 
> added some
>   warnings to manuals. But trying to change the way they work because
>   we think we know better what users want, and changing BTW some other
>   things (making debugging this later a hell), is simply disrespectful
>   for target users of these tools. There are some wrappers or 
> "creators"
>   invented for this. And, BTW, I think I've seen somewhere a system
>   which does this this other way - with creators for 
> professionals. So,
>   you could be right with this too...

Ok, maybe I'm not done quite yet.  Jarek is echo'ing my original point,
changing the behavior of the tool automatically (these qdiscs in
question) is not good for a normal end user.  It might be fine for
kernel developers, but not users of these tools, IMO.  A less disruptive
approach, such as a warning message printed when loading the qdisc if
TSO is enabled, and documenting recommended usage, I think is more
prudent here.

Cheers,
-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html