netdev - Re: [patch 00/14] replace __inline_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Feb 2008 03:29:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dlezcano@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [patch 00/14] replace __inline__ by inline in net code

From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Wed, 06 Feb 2008 10:14:05 +0100

> The following patchset replaces all occurences of __inline__
> by inline and make some minor coding style fixes.
> 
> It touches:
>   . net/* files
>   . include/net/* files
>   . include/linux/* files (only the ones related to the network)
> 
> The patchset touches a lot of files and that can probably increase
> the patch conflict probability, but I have this patchset since a 
> few days, I didn't noticed any problem when updating net-2.6 and I
> hope that will be still the case.
> IMHO, it is the right moment to send this patch out, since net-2.6.25
> is closed and net-2.6.26 is not yet opened.

You have a point, but you also don't.

This makes debugging much harder since they not only have to go
through the real changes, they also have to go through transformations
like this one.

I'd much rather queue this up into net-2.6.26 when I open that up and
deal with whatever rejects.  For trivial transformations like this I
can resolve the rejects with my eyes closed. :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html