netdev - Re: [PATCH 1/4] rcu_assign_pointer: null check fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Feb 2008 08:07:41 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernle.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] rcu_assign_pointer: null check fix

On 13-02-2008 01:50, Stephen Hemminger wrote:
...
> --- a/include/linux/rcupdate.h	2008-02-12 14:46:49.000000000 -0800
> +++ b/include/linux/rcupdate.h	2008-02-12 14:56:17.000000000 -0800
> @@ -178,7 +178,7 @@ struct rcu_head {
>  
>  #define rcu_assign_pointer(p, v)			\
>  	({						\
> -		if (!(__builtin_constant_p(v) && v))	\
> +		if (!__builtin_constant_p(v) || v)	\

Isn't it a bit safer with this Paul's version yet?:

 +		if (!__builtin_constant_p(v) || (v))	\

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html