netdev - Re: [PATCH] tg3: ethtool phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Feb 2008 11:16:42 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Stephen Hemminger" <shemminger@...tta.com>
cc:	"David Miller" <davem@...emloft.net>,
	"Jeff Garzik" <jgarzik@...ox.com>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] tg3: ethtool phys_id default (rev2)

On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote:
> When asked to blink LEDs the tg3 driver behaves when using:
> 	ethtool -p ethX
> The default value for data is zero, and other drivers interpret this
> as blink forever (or at least a really long time).  The tg3 driver
> interprets this as blink once.  All drivers should have the same
> behaviour.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Acked-by: Michael Chan <mchan@...adcom.com>

We should do this across the board for bnx2, bnx2x, and niu as well.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html