netdev - Re: [patch 2.6.25-rc3] smc91x section fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Feb 2008 22:33:12 -0800
From:	David Brownell <david-b@...bell.net>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	nico@....org, netdev@...r.kernel.org
Subject: Re: [patch 2.6.25-rc3] smc91x section fix

On Sunday 24 February 2008, Sam Ravnborg wrote:

> From a quick look this is wrong.
> smc_drv_probe is assined the .probe member so it is used during
> hotplug and thus should be __devinit.
> Likewise smc_probe is used by smc_drv_probe and thus smc_probe
> should be __devinit too.

Thing is, with only rare exceptions, devices on the platform
bus are *NOT* hotpluggable.  So using __devinit/__devexit and
friends adds up to no more than a waste of I-space.

Nico may know if this driver is one of the rare exceptions.
Example, is it used in PCMCIA cards?

See also platform_driver_probe(), which is a much safer way
to handle such issues.  I've seen it save a full page in some
drivers, but usually it's less.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html