netdev - Re: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Feb 2008 08:38:19 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Wappler Marcel" <Marcel.Wappler@...dgeco.net>
Cc:	"Patrick McHardy" <kaber@...sh.net>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <ebiederman@...i.com>
Subject: Re: [PATCH] [resend]The kernel gets no IP from some DHCP servers,
 2.6.24

On Wed, 27 Feb 2008 14:11:55 +0100
"Wappler Marcel" <Marcel.Wappler@...dgeco.net> wrote:

> -----Original Message-----
> >>  #include <linux/types.h>
> >> @@ -103,6 +107,7 @@
> >>  					   - '3' from resolv.h */
> >>  
> >>  #define NONE __constant_htonl(INADDR_NONE)
> >> +#define ZERO __constant_htonl(((unsigned long int) 0x00000000))
> >This should probably use INADDR_ANY.
> My first try went in this direction. But at a second look I thought
> that the names ANY (255.255.255.255) and NONE (0.0.0.0) are indirect
> leading to confusion. The interpretation of the zero addresses in
> the DHCPDISCOVER packet is in the kind of 'no address' and not of
> 'any addressee'. So the meaning and usage of INADDR_ANY and ZERO
> may be totally different in this file.
> In my opinion it is necessary to distinguish between INADDR_ANY
> and the ZERO address which ist requested to be in the DHCPDISCOVER
> packet.
> 

Just delete the lines and the address will be zero because of
earlier memset().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html