netdev - RE: [PATCH] [NET 2.6.26]: Add per-connection option to set max TSOframe size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Feb 2008 09:16:01 -0800
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"Jarek Poplawski" <jarkao2@...il.com>
Cc:	<davem@...emloft.net>, <stephen.hemminger@...tta.com>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH] [NET 2.6.26]: Add per-connection option to set max TSOframe   size

> >  	dev->egress_subqueue_count = queue_count;
> > +	dev->max_gso_frame_size = 65536;
> 
> Does it fit into u16?

No it doesn't.  I originally had this as an int, and borked it when
switching it to unsigned.  I'll fix this asap.

> Isn't it "nicer" with some constant (#define MAX_GSO_FRAME_SIZE ...)?

Yes it is.  I'll add this.

> Why not more consistent names, e.g.:
> dev->gso_max_size;
> sk_gso_max_size;
> netif_set_gso_max_size()
> (GSO_MAX_SIZE)
> or
> dev->max_gso_frame_size;
> sk_max_gso_frame_size;
> netif_set_max_gso_frame_size()
> (MAX_GSO_FRAME_SIZE)
> etc.?

Very good point.  I'll change this and resend today.  Thanks a bunch for
the feedback!

Cheers,

-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html