netdev - Re: [PATCH 09/15] [PKTGEN]: Use proc_create() to setup ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Feb 2008 14:12:42 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 09/15] [PKTGEN]: Use proc_create() to setup ->proc_fops
 first

From: Wang Chen <wangchen@...fujitsu.com>
Date: Thu, 28 Feb 2008 18:57:18 +0800

> Use proc_create() to make sure that ->proc_fops be setup before gluing
> PDE to main tree.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Applied.

> @@ -3570,14 +3570,14 @@ static int pktgen_add_device(struct pktgen_thread *t, const char *ifname)
>  	if (err)
>  		goto out1;
>  
> -	pkt_dev->entry = create_proc_entry(ifname, 0600, pg_proc_dir);
> +	pkt_dev->entry = proc_create(ifname, 0600,
> +				     pg_proc_dir, &pktgen_if_fops);
>  	if (!pkt_dev->entry) {
>  		printk(KERN_ERR "pktgen: cannot create %s/%s procfs entry.\n",
>  		       PG_PROC_DIR, ifname);
>  		err = -EINVAL;
>  		goto out2;
>  	}
> -	pkt_dev->entry->proc_fops = &pktgen_if_fops;
>  	pkt_dev->entry->data = pkt_dev;
>  #ifdef CONFIG_XFRM
>  	pkt_dev->ipsmode = XFRM_MODE_TRANSPORT;

->data visibility issue

> @@ -3638,7 +3638,6 @@ static int __init pktgen_create_thread(int cpu)
>  		return -EINVAL;
>  	}
>  
> -	pe->proc_fops = &pktgen_thread_fops;
>  	pe->data = t;
>  
>  	wake_up_process(p);

Likewise.

> @@ -3717,7 +3716,6 @@ static int __init pg_init(void)
>  		return -EINVAL;
>  	}
>  
> -	pe->proc_fops = &pktgen_fops;
>  	pe->data = NULL;
>  
>  	/* Register us to receive netdevice events */

Superfluous assignment to NULL, can be deleted.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html