netdev - Re: RFC [PATCH 2/3] TCP_DEFER_ACCEPT updates: don't retransmit syn-ack while waiting for first data byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 01 Mar 2008 11:42:51 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Patrick McManus <mcmanus@...ksong.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: RFC [PATCH 2/3] TCP_DEFER_ACCEPT updates: don't retransmit syn-ack
 while waiting for first data byte

Patrick McManus a écrit :
> Signed-off-by: Patrick McManus <mcmanus@...ksong.com>
> 
>     a socket in LISTEN that had completed its 3 way handshake, but not notified
>     userspace because of SO_DEFER_ACCEPT, would retransmit the already
>     acked syn-ack during the time it was waiting for the first data byte
>     from the peer.
> 
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index 03cc323..7216f5e 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -461,8 +461,9 @@ void inet_csk_reqsk_queue_prune(struct sock *parent,
>                 reqp=&lopt->syn_table[i];
>                 while ((req = *reqp) != NULL) {
>                         if (time_after_eq(now, req->expires)) {
> -                               if ((req->retrans < (inet_rsk(req)->acked ? max_retries : thresh))
> -                                   && !req->rsk_ops->rtx_syn_ack(parent, req, NULL)) {
> +                               if ((req->retrans < (inet_rsk(req)->acked ? max_retries : thresh))
> +                                   &&  (inet_rsk(req)->acked ||
> +                                        !req->rsk_ops->rtx_syn_ack(parent, req, NULL))) {
>                                         unsigned long timeo;
> 
>                                         if (req->retrans++ == 0)
> 
> 

Acked-by: Eric Dumazet <dada1@...mosbay.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html