netdev - Re: pull request: wireless-2.6 2008-02-27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Mar 2008 17:44:29 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	"John W. Linville" <linville@...driver.com>,
	Johannes Berg <johannes@...solutions.net>,
	Michael Buesch <mb@...sch.de>,
	David Miller <davem@...emloft.net>,
	gordonfarquharson@...il.com, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: pull request: wireless-2.6 2008-02-27

On Sat, Mar 01, 2008 at 02:01:33PM +0100, Sam Ravnborg wrote:
> On Fri, Feb 29, 2008 at 04:42:40PM -0500, John W. Linville wrote:
> > On Fri, Feb 29, 2008 at 02:10:58PM -0500, John W. Linville wrote:
> > > On Fri, Feb 29, 2008 at 05:34:13PM +0100, Johannes Berg wrote:
> > > > 
> > > > On Fri, 2008-02-29 at 11:26 -0500, John W. Linville wrote:
> > > > > On Fri, Feb 29, 2008 at 01:16:59PM +0100, Michael Buesch wrote:
> > > > > 
> > > > > > I'm wondering if we can't simply pass a commandline parameter to file2alias
> > > > > > that tells it whether we are crosscompiling. It should simply omit the sanity check
> > > > > 
> > > > > Sounds reasonable to me.
> > > > 
> > > > In fact, file2alias shouldn't need a command line argument ...
> > > > 
> > > > > > in that case. Is there any easy and reliable way to find out whether we
> > > > > > are crosscompiling from a makefile (I don't know the makefile core that much)?
> > > > > 
> > > > > Non-empty CROSS_COMPILE definition?
> > > > 
> > > > ... it can just check whether CROSS_COMPILE is set in its environment.
> > > > No?
> > > 
> > > Not a bad idea...something like this?
> > 
> > That version didn't work -- it seems CROSS_COMPILE is always set,
> > even if it is empty.
> > 
> > This version seems to work, but it is a bit chatty when CROSS_COMPILE
> > is set and you build lots of modules...thoughts?
> 
> We cannot use CROSS_COMPILE to detect a cross build as CROSS_COMPILE
> is used used to select different gcc versions, cccache etc.
> The only relaiably way to detect a cross build is to check
> is ARCH != modified uname -m arch.
> So this check would have to be done in the top-level Makefile.
> 
> And that for shaving 6 bytes of a structure..

I remember two other occassions where this file2alias mess has bitten us 
recently.

I don't mind that much how it gets fixed, but the current status quo of 
having this kind of problems again and again is simply not acceptable.

> 	Sam

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html