netdev - Re: [PATCH 2/4 net-2.6.26] [IPV4]: Cleanup ip_options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2008 15:02:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	den@...nvz.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/4 net-2.6.26] [IPV4]: Cleanup ip_options_compile.

From: "Denis V. Lunev" <den@...nvz.org>
Date: Tue, 04 Mar 2008 01:57:31 +0300

> On Mon, 2008-03-03 at 13:24 -0800, David Miller wrote:
> > I suppose it gets used by ip_options_build() for outgoing
> > packets, which assumes that is_data is always set?
> 
> is_data is checked in the only place in the code, in the
> ip_options_compile. It, in turn is called twice in the original code:
> 
> ip_options_get_finish
>         opt->is_data = 1;    <-- !!!
>         if (optlen && ip_options_compile(opt, NULL))
> 
> ip_rcv_options
>    if (ip_options_compile(NULL, skb)) {
> 
> So, (opt && !opt->is_data) is impossible in the orignal code where it is
> checked.

Ok, fixup the cipso build failure and resubmit.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html